Page 3 of 7

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 12:03 pm
by Batlin
So you are saying that melee uses the "finalized" damage value instead of the value before it's cut in half on the demo Batlin?
That's exactly what I am saying, comparing the recorded damage values by the modified script with the hit points dropping gives no doubt about that. Plus the code path inside the core supports the seen behavior.

Code: Select all

FUNC_DoDamage(...) // called by the scripts only
{
  ...
  FUNC_GoDoScriptTrigger(..., washit, DamageValue);
  ...
  FUNC_DoDamageInternal(..., DamageValue, DamageType, ...);
}

FUNC_DoDamageInternal(...) // called by the scripts indirectly and by melee directly
{
  ...
  FUNC_GoModifyDamage(..., DamageType, &DamageValue); // by reference
  ...
  DamageValue = DamageValue / 2;
  ...
  FUNC_GoDoScriptTrigger(..., washit, DamageValue);
  ...
}
Why would there be two checks for chance of interruption unless there was one check intially made to see if there was interuption and if the interruption succeeded there was the second check made to see if it was still interrupted if the spell was resisted?
Of course, in case of interruption it would be logical that the second check is not made. The only reason I want to investigate this further is because I do not know at what point the second check is ignored. I don't see any clear code path that would cause this behaviour.

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 12:04 pm
by Hemperor
Derrick wrote:The proposed changes have been made on test center.
While we are still looking into some of the "wierdness" that Batlin mentioned, I belive what is currently on testcenter is more correct than what we have now.

Server: test.uosecondage.com
Port: 2593
Great job on getting this on test so fast, I'll have to kick my girlfriend out early for this one

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 12:18 pm
by Faust
Was the debuff fix included with this?

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 12:45 pm
by Batlin
Was the debuff fix included with this?
What do you mean exactly with this one?

I'll probably answer in about 3-4 hours, I'm gonna work in my house now.

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 12:48 pm
by Faust
Derrick said that he put some changes up on test with a lot of this new information. I was wondering if he fixed debuffs to be included with this. Debuffs use a hundred percent guarentee disrupt and should be used in the standard spell interruption formula with a damage value of 0 based on your research.

So was just wondering if this was included in test too? :wink:

Great work Batlin.

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 3:17 pm
by poogoblin
Batlin wrote:
So you are saying that melee uses the "finalized" damage value instead of the value before it's cut in half on the demo Batlin?
That's exactly what I am saying, comparing the recorded damage values by the modified script with the hit points dropping gives no doubt about that. Plus the code path inside the core supports the seen behavior.

Code: Select all

FUNC_DoDamage(...) // called by the scripts only
{
  ...
  FUNC_GoDoScriptTrigger(..., washit, DamageValue);
  ...
  FUNC_DoDamageInternal(..., DamageValue, DamageType, ...);
}

FUNC_DoDamageInternal(...) // called by the scripts indirectly and by melee directly
{
  ...
  FUNC_GoModifyDamage(..., DamageType, &DamageValue); // by reference
  ...
  DamageValue = DamageValue / 2;
  ...
  FUNC_GoDoScriptTrigger(..., washit, DamageValue);
  ...
}
Did this part make it into the test patch as well?

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 4:23 pm
by Redbeard72
Kraarug wrote:
Redbeard72 wrote:ok for a lame ass, What is this going to do, slow pvp down or speed it up, or make it so that i wont get disrupted every time i try to recall my bard to escape?
It will make it Era Accurate.

Right now, melee damage appears to be acting correctly.

Faust is saying that there we as double check for magery damage so, when this goes into effect one will get interrupted more with magery attacks.

This will also more than likely lead to interruption from poison damage as well.
Well i dont remember getting disrupted alot more then the way it is now, if its just a tad more then, well i could c that, but i do remember Poison took them along time to change that so the slow poisons would almost kill you cause u couldnt recall. disrupt tick disrupt tick. lol love all of you guys... GOood work to you all.

Re: Spell Interrption:

Posted: Fri Aug 21, 2009 7:44 pm
by Derrick
Faust wrote:Was the debuff fix included with this?
No, not yet. I snapped this off pretty fast.

To the question on the melee change, I'm really still waiting to see what shakes out of Batlins research.
The change on test center passes pre-halved damage to the interrupt check.

For the questions on the previous page about resist, the pre halved damage is not the damage after resist. All damage is halved before applied; weapons, spells etc... For more into on this, read the original post in this thread, and the posts in the Deadly Poison thread stating at the bottom of page 3.

Re: Spell Interrption:

Posted: Sun Aug 23, 2009 11:27 pm
by Faust
Will there be two checks for magical attacks too?

Re: Spell Interrption:

Posted: Fri Aug 28, 2009 4:20 pm
by Faust
What is the current status for this process for all three parts of this system?

- Disrupts Fixed on a base damage of 0.
- Double calls for spells and effects using the pre-determined and finalized damage for the 1st and 2nd call.
- One call for finalized melee damage.

Wouldn't seem more beneficial to be able to test the entire system as a whole instead of bits and pieces of it in my opinion.

Re: Spell Interrption:

Posted: Sat Aug 29, 2009 9:30 pm
by Derrick
It's not done yet, I have hoped to get to work on this and finalize but have had a busy week (really a busy month).

I do hope to roll this out to test soon, The double calls are the only thing holding us up.

Re: Spell Interrption:

Posted: Sat Aug 29, 2009 11:14 pm
by archaicsubrosa77
Do debuffs unparalyze you? I never seen nor used the paralyze debuff combo ever and cant try it out right now.
If they dont unparalyze you then they should not interrupt, if they do not unparalyze you it would be nice to use this in pvp.

Re: Spell Interrption:

Posted: Sat Aug 29, 2009 11:21 pm
by Derrick
archaicsubrosa77 wrote:Do debuffs unparalyze you? I never seen nor used the paralyze debuff combo ever and cant try it out right now.
If they dont unparalyze you then they should not interrupt, if they do not unparalyze you it would be nice to use this in pvp.
It's a good question on whether they did on OSI, I actually belive they would in demo. Defbuffs have without a doubt been shown to interrupt, but it's not 100% as we currently have implemented on UOSA

Re: Spell Interrption:

Posted: Sun Aug 30, 2009 12:17 pm
by Derrick
Faust wrote:What is the current status for this process for all three parts of this system?

- Disrupts Fixed on a base damage of 0.
- Double calls for spells and effects using the pre-determined and finalized damage for the 1st and 2nd call.
- One call for finalized melee damage.

Wouldn't seem more beneficial to be able to test the entire system as a whole instead of bits and pieces of it in my opinion.
The entire proposed system is now on test center. It's completely untested, please test.
- The double calls for disturb check are in
- Debuff disrupts use a damage value of zero
- Wrestling speed has been reduced from 55 to 50

Server: test.uosecondage.com
Port: 2593

Re: Spell Interrption:

Posted: Sun Aug 30, 2009 12:41 pm
by Hemperor
nice!