Page 1 of 1
I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 7:02 pm
by MatronDeWinter
Server Publish Feb 23 2000 10:22AM CST
Trade Window Changes
Trade windows will become more secure.
* You will not be able to trade a trapped item.
* You will not be able to trade an item that was recently stolen.
* You will not be able to trade items to a player if that player cannot hold the items.
o If the items are too heavy for the player or if the items would exceed the number of items the player can carry, the trade will fail. All items in the trade window will go back into each character’s pack.
* You will not be able to pick items up while the trade window is open. However, you will still be able to rearrange items in your own pack during the trade.
This patch is quite a ways after out target window. I feel that specifically now, since we are seeing changes to minor things such as cutting bandaids and the way house deeds work we could address this issue.
I personally would like to see this changed for 2 reasons.
1.)
If you are looting someone/something, someone else can just toss up a trade window and you can no longer loot.
2.)
I would really like put an end to people attempting to trade chests/pouches to determine if they are trapped. In my opinion this is a serious oversight that negates the usefullness of magery and the detect hidden skill.
Discuss.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 7:05 pm
by Hemperor
I've mentioned this before and it's been confirmed, I'll throw it on the to-do list as I'm missing a few other things on there as well.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 7:08 pm
by Fwerp
Well, it's era accurate, but it's simply going to result in poor saps being scammed like crazy.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 7:29 pm
by MatronDeWinter
Fwerp wrote:Well, it's era accurate, but it's simply going to result in poor saps being scammed like crazy.
This is why I put it in the discussion section instead of just creating a bug report. Incase there was some better "compromise" that would be beneficial. I'm not fond of the weight-limit trade scam myself, but I would like to see the above mentioned items taken care of.
/Thanks hemperor, for the list add.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 9:07 pm
by Biohazard
MatronDeWinter wrote:Server Publish Feb 23 2000 10:22AM CST
Trade Window Changes
Trade windows will become more secure.
* You will not be able to trade a trapped item.
* You will not be able to trade an item that was recently stolen.
* You will not be able to trade items to a player if that player cannot hold the items.
o If the items are too heavy for the player or if the items would exceed the number of items the player can carry, the trade will fail. All items in the trade window will go back into each character’s pack.
* You will not be able to pick items up while the trade window is open. However, you will still be able to rearrange items in your own pack during the trade.
This patch is quite a ways after out target window. I feel that specifically now, since we are seeing changes to minor things such as cutting bandaids and the way house deeds work we could address this issue.
I personally would like to see this changed for 2 reasons.
1.)
If you are looting someone/something, someone else can just toss up a trade window and you can no longer loot.
2.)
I would really like put an end to people attempting to trade chests/pouches to determine if they are trapped. In my opinion this is a serious oversight that negates the usefullness of magery and the detect hidden skill.
Discuss.
...and not to mention me trying to give people trapped chests directly and I can't
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 10:16 pm
by Pristiq
Aye, I agree with Matron. This patch is so far out of era it's ridiculous to even consider having it implemented here.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 10:19 pm
by Hemperor
Pristiq wrote:Aye, I agree with Matron. This patch is so far out of era it's ridiculous to even consider having it implemented here.
It's in by default.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 10:26 pm
by Pristiq
Hemperor wrote:It's in by default.
I know. I meant it was ridiculous to even consider leaving it in. (Bad wording on my end.)
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 10:28 pm
by Hemperor
Pristiq wrote:Hemperor wrote:It's in by default.
I know. I meant it was ridiculous to even consider leaving it in. (Bad wording on my end.)
Things take time to be done. Messing with RunUO lately, it really is amazing the amount of changes done so far. Literally every single aspect of the game (literally) has to be changed when making a shard like this.
Re: I think it's time for new trade-window rules?
Posted: Tue Jul 28, 2009 10:47 pm
by archaicsubrosa77
Where does it say anything about not being able to throw up a trade window while someone is looting? How the heck can you fix that? They tried to tone it down a little by making you visible when looting except for your own corpse. That way you wouldnt have the hidden window up as you loot your own corpse while the guy is looting it right with you throwing an invisible trade window up.
Re: I think it's time for new trade-window rules?
Posted: Wed Jul 29, 2009 7:23 am
by MatronDeWinter
archaicsubrosa77 wrote:Where does it say anything about not being able to throw up a trade window while someone is looting? How the heck can you fix that? They tried to tone it down a little by making you visible when looting except for your own corpse. That way you wouldnt have the hidden window up as you loot your own corpse while the guy is looting it right with you throwing an invisible trade window up.
The point is, you should be able to loot or do whatever else even with a trade window open.
From the patch during uoR
"* You will not be able to pick items up while the trade window is open. "
With this patch enabled, if I were looting hemperor, and Tekai came along and opened up a trade window repeatedly with me, I would no longer be able to loot hemperor.
Re: I think it's time for new trade-window rules?
Posted: Wed Jul 29, 2009 8:54 am
by archaicsubrosa77
Okay...so you want the trade and be able to steal exploit that comes with dragging an item from any other gump open while the trade window is up....
If I am not mistaken though this technique was also used during T2A, I believe I came across excerpts of its use I posted in another thread.
Re: I think it's time for new trade-window rules?
Posted: Wed Jul 29, 2009 9:21 am
by Hiram
The appropriate code can be found in PlayerMobile.cs CheckTrade for weight check failure.
Just remove the IF statements for the lines around this stuff:
if ( this.Backpack == null
else if ( to.Backpack == null
Code: Select all
public override bool CheckTrade( Mobile to, Item item, SecureTradeContainer cont, bool message, bool checkItems, int plusItems, int plusWeight )
{
int msgNum = 0;
if ( cont == null )
{
if ( to.Holding != null )
msgNum = 1062727; // You cannot trade with someone who is dragging something.
else if ( this.HasTrade )
msgNum = 1062781; // You are already trading with someone else!
else if ( to.HasTrade )
msgNum = 1062779; // That person is already involved in a trade
}
if ( msgNum == 0 )
{
if ( cont != null )
{
plusItems += cont.TotalItems;
plusWeight += cont.TotalWeight;
}
if ( this.Backpack == null || !this.Backpack.CheckHold( this, item, false, checkItems, plusItems, plusWeight ) )
msgNum = 1004040; // You would not be able to hold this if the trade failed.
else if ( to.Backpack == null || !to.Backpack.CheckHold( to, item, false, checkItems, plusItems, plusWeight ) )
msgNum = 1004039; // The recipient of this trade would not be able to carry this.
else
msgNum = CheckContentForTrade( item );
}
if ( msgNum != 0 )
{
if ( message )
this.SendLocalizedMessage( msgNum );
return false;
}
return true;
}
In the same file you find CheckContentForTrade where you can remove the trappable and stolen items checks:
Code: Select all
private static int CheckContentForTrade( Item item )
{
if ( item is TrapableContainer && ((TrapableContainer)item).TrapType != TrapType.None )
return 1004044; // You may not trade trapped items.
if ( SkillHandlers.StolenItem.IsStolen( item ) )
return 1004043; // You may not trade recently stolen items.
if ( item is Container )
{
foreach ( Item subItem in item.Items )
{
int msg = CheckContentForTrade( subItem );
if ( msg != 0 )
return msg;
}
}
return 0;
}
I am all for these changes!
